Thread (9 messages) 9 messages, 3 authors, 2021-10-08

Re: [dpdk-dev] [PATCH v3] net/i40e: fix Rx packet statistics

From: Zhang, Qi Z <hidden>
Date: 2021-10-08 06:17:44

-----Original Message-----
From: Zhang, AlvinX <redacted>
Sent: Thursday, September 30, 2021 1:20 PM
To: Xing, Beilei <redacted>; Guo, Junfeng
[off-list ref]; ktraynor@redhat.com; Zhang, Qi Z
[off-list ref]
Cc: dev@dpdk.org; Zhang, AlvinX <redacted>; stable@dpdk.org
Subject: [PATCH v3] net/i40e: fix Rx packet statistics

Some packets are discarded by the NIC because they are larger than the MTU,
these packets should be counted as "RX error" instead of "RX packet", for
example:

  pkt1 = Ether()/IP()/Raw('x' * 1400)
  pkt2 = Ether()/IP()/Raw('x' * 1500)

  ---------------- Forward statistics for port 0 -----------------
  RX-packets: 2 RX-dropped: 0 RX-total: 2
  TX-packets: 1 TX-dropped: 0 TX-total: 1
  ----------------------------------------------------------------

  Here the packet pkt2 has been discarded, but still was counted
  by "RX-packets"

The register 'GL_RXERR1' can count above discarded packets.
This patch adds reading and calculation of the 'GL_RXERR1' counter when
reporting DPDK statistics.

Fixes: f4a91c38b4ad ("i40e: add extended stats")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <redacted>
Acked-by: Qi Zhang <redacted>

Applied to dpdk-next-net-intel.

Thanks
Qi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help