Re: [dpdk-dev] [PATCH v7 1/9] bbdev: add big endian processing data processing info
From: Chautru, Nicolas <hidden>
Date: 2021-10-04 23:10:08
-----Original Message----- From: nipun.gupta@nxp.com <redacted> Sent: Tuesday, September 28, 2021 1:30 AM To: dev@dpdk.org; gakhil@marvell.com; Chautru, Nicolas [off-list ref] Cc: david.marchand@redhat.com; hemant.agrawal@nxp.com; Nipun Gupta [off-list ref] Subject: [PATCH v7 1/9] bbdev: add big endian processing data processing info From: Nipun Gupta <redacted> This patch intoduces a new info pertaining to bbdev device to process the data in big endian order.
Typo in commit message
quoted hunk ↗ jump to hunk
Signed-off-by: Nipun Gupta <redacted> --- lib/bbdev/rte_bbdev.h | 2 ++ 1 file changed, 2 insertions(+)diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index7017124414..3acc008d06 100644--- a/lib/bbdev/rte_bbdev.h +++ b/lib/bbdev/rte_bbdev.h@@ -309,6 +309,8 @@ struct rte_bbdev_driver_info { uint16_t min_alignment; /** HARQ memory available in kB */ uint32_t harq_buffer_size; + /** Device support input, output and HARQ data as big-endian */ + uint8_t support_be_data;
Shouldn't this either be a bool or even better an enum? Ie. as per rte_bbdev_op_cb_mode enum for instance Having 0/1 magic number in the code will always be misleading
/** Default queue configuration used if none is supplied */ struct rte_bbdev_queue_conf default_queue_conf; /** Device operation capabilities */ -- 2.17.1