Re: [dpdk-dev] [PATCH v8 5/5] ethdev: merge driver ops to get all xstats names and by ID
From: Andrew Rybchenko <hidden>
Date: 2021-10-01 09:06:50
From: Andrew Rybchenko <hidden>
Date: 2021-10-01 09:06:50
On 9/30/21 7:47 PM, Ferruh Yigit wrote:
On 9/30/2021 5:05 PM, Andrew Rybchenko wrote:quoted
All xstats names may be retrieved passing NULL ids. If a driver does not support getting names by IDs, the callback should return -ENOTSUP on attempt to use it. If so, the request is handled on ethdev layer by getting all names and filtering out requested only.Since '-ENOTSUP' has special meaning (request ethdev layer fallback), I think it would be good to explicitly document this in the dev_ops comment.
Yes, good idea. Done in v9.
quoted
Signed-off-by: Andrew Rybchenko <redacted>