Re: [dpdk-dev] [PATCH v6 04/10] mbuf: add IPsec ESP tunnel type
From: Nicolau, Radu <hidden>
Date: 2021-09-30 09:04:06
On 9/23/2021 1:59 PM, Ananyev, Konstantin wrote:
quoted
Add tunnel type for IPsec ESP tunnels Signed-off-by: Declan Doherty <redacted> Signed-off-by: Radu Nicolau <redacted> Signed-off-by: Abhijit Sinha <redacted> Signed-off-by: Daniel Martin Buckley <redacted> Acked-by: Fan Zhang <redacted> Acked-by: Akhil Goyal <redacted> Acked-by: Olivier Matz <redacted> --- lib/mbuf/rte_mbuf_core.h | 1 + 1 file changed, 1 insertion(+)diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h index bb38d7f581..a4d95deee6 100644 --- a/lib/mbuf/rte_mbuf_core.h +++ b/lib/mbuf/rte_mbuf_core.h@@ -253,6 +253,7 @@ extern "C" { #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45) #define PKT_TX_TUNNEL_VXLAN_GPE (0x6ULL << 45) #define PKT_TX_TUNNEL_GTP (0x7ULL << 45) +#define PKT_TX_TUNNEL_ESP (0x8ULL << 45)As I can see, that's not ptype, that's TX flag. Could you clarify what exactly what flag would mean for PMD TX: - what is expected from the user who sets this flag - what is expected from PMD that claims to support it. BTW, would we need new DEV_TX_OFFLOAD_* for it?
There is documentation above for the other tunnel types, they are supposed to be used for TSO purposes. I will update the commit message to clarify this.
quoted
/** * Generic IP encapsulated tunnel type, used for TSO and checksum offload. * It can be used for tunnels which are not standards or listed above. -- 2.25.1