Re: [dpdk-dev] [PATCH 2/2] security: build on Windows

Subject: Re: [PATCH 2/2] security: build on Windows

External email: Use caution opening links or attachments


On 9/15/2021 9:26 AM, Tal Shnaiderman wrote:

quoted

Build the security library on Windows.

Remove unneeded export from version file.

Signed-off-by: Tal Shnaiderman <redacted>
---
Depends-on: patch-98796 ("cryptodev: build on Windows")
---
  lib/meson.build          | 1 +
  lib/security/version.map | 1 -
  2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/meson.build b/lib/meson.build index

5f3b1cf365..e5f0094a82 100644

--- a/lib/meson.build
+++ b/lib/meson.build

@@ -86,6 +86,7 @@ if is_windows
              'gso',
              'latencystats',
              'pdump',
+            'security',
      ] # only supported libraries for windows
  endif

diff --git a/lib/security/version.map b/lib/security/version.map index

c44c7f5f60..6067051552 100644

--- a/lib/security/version.map
+++ b/lib/security/version.map

@@ -1,7 +1,6 @@
  DPDK_22 {
      global:

-     rte_security_attach_session;
      rte_security_capabilities_get;
      rte_security_capability_get;
      rte_security_session_create;

Getting linking errors using clang for 'rte_security_get_userdata' and
'rte_security_set_pkt_metadata' as below:

FAILED: lib/rte_security-22.dll
"clang"  -Wl,/MACHINE:X64 -Wl,/OUT:lib/rte_security-22.dll
lib/librte_security.a.p/security_rte_security.c.obj "-Wl,/nologo"
"-Wl,/release" "-Wl,/nologo" "-Wl,/OPT:REF" "-Wl,/DLL"
"-Wl,/IMPLIB:lib\rte_security.lib" "lib\rte_eal.lib"
"lib\rte_kvargs.lib" "lib\rte_mempool.lib" "lib\rte_ring.lib"
"lib\rte_cryptodev.lib" "lib\rte_mbuf.lib" "lib\rte_rcu.lib"
"lib\rte_net.lib"
"-Wl,/def:C:\dpdk\ixgbe\dpdk\build\lib\rte_security_exports.def"
"-ldbghelp" "-lsetupapi" "-lws2_32" "-lmincore" "-lkernel32" "-luser32"
"-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid"
"-lcomdlg32" "-ladvapi32"
rte_security_exports.def : error LNK2001: unresolved external symbol
rte_security_get_userdata rte_security_exports.def : error LNK2001:
unresolved external symbol rte_security_set_pkt_metadata
lib\rte_security.lib : fatal error LNK1120: 2 unresolved externals
clang: error: linker command failed with exit code 1120 (use -v to see
invocation)

Should it be removed from version file?

Yes, those 2 functions were changed in the patch below after my v1 was sent and no longer need export.

https://git.dpdk.org/dpdk/commit/?id=d08dcd28c3b245468a9859b7b9a288247dfc95f1

I'll remove them from the version file in v2 as suggested, thanks.