Thread (122 messages) 122 messages, 5 authors, 2021-10-09

Re: [dpdk-dev] [PATCH v4 01/18] net/i40e/base: add new versions of send ASQ command functions

From: Ferruh Yigit <hidden>
Date: 2021-09-29 16:21:32

On 9/6/2021 3:02 AM, Robin Zhang wrote:
ASQ send command functions are returning only i40e status codes
yet some calling functions also need Admin Queue status
that is stored in hw->aq.asq_last_status. Since hw object
is stored on a heap it introduces a possibility for
a race condition in access to hw if calling function is not
fast enough to read hw->aq.asq_last_status before next
send ASQ command is executed.

Added new versions of send ASQ command functions that return
Admin Queue status on the stack to avoid race conditions
in access to hw->aq.asq_last_status.
Added new _v2 version of i40e_aq_remove_macvlan and i40e_aq_add_macvlan
that is using new _v2 versions of ASQ send command functions and
returns the Admin Queue status on the stack.

Signed-off-by: Sylwester Dziedziuch <redacted>
Signed-off-by: Robin Zhang <redacted>

I assume ASQ is "Admin Send Queue" (although datasheet refers to it as ATQ), can
you please give the long version of the abbreviations in the commit log in first
usage as:
"ASQ (Admin Send Queue) ... "
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help