Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag
From: Andrew Rybchenko <hidden>
Date: 2021-09-29 06:39:01
From: Andrew Rybchenko <hidden>
Date: 2021-09-29 06:39:01
On 9/28/21 8:10 PM, Stephen Hemminger wrote:
On Tue, 28 Sep 2021 19:48:54 +0300 Andrew Rybchenko [off-list ref] wrote:quoted
Some drivers do not provide per-queue statistics. So, there is no point to have these misleading zeros in xstats. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko <redacted>Really? It is useful to have zeros rather than random data there.
I guess there is a misunderstanding here. Auto-filling xstats is an addition of per-queue basic statistics to xstats by ethdev layer. It makes sense to do it if and only if there is some sensible data there. There is a related deprecation notice saying that per-queue stats should be removed from basic stats since per-queue stats should be provided by xstats API natively. Basically RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS means that corresponding driver is not ready vs the deprecation notice. So, I want to clean it up to see not yet ready drivers only.