Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering
From: Pattan, Reshma <hidden>
Date: 2021-09-24 15:33:30
From: Pattan, Reshma <hidden>
Date: 2021-09-24 15:33:30
-----Original Message-----quoted
quoted
+ * Similar behavior to rte_bpf_eth callback. + * if BPF program returns zero value for a given packet, + * then it will be ignored. + */Looks like wrong callback name referred in the comment, should becorrected? It really is pcap_offline_filter() and Linux kernel socket filter.
Oh ok, rcs[i] is basically "return value of the filter program. This will be zero if the packet doesn't match the filter and non-zero if the packet matches the filter." got it now on why is the below if check.
quoted
quoted
+ if (cbs->filter && rcs[i] == 0) {