Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
From: Thomas Monjalon <hidden>
Date: 2021-09-17 16:15:48
17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil:
From: Thomas Monjalon <redacted>quoted
17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:quoted
From: Thomas Monjalon <redacted>quoted
17/09/2021 12:58, Ashwin Sekhar T K:quoted
Update word list with Marvell specific acronyms.
[...]
quoted
Please add details in the commit log so we understand they are Marvell acronyms.Commit log already mentions these are Marvell specific acronyms. I did not add explanation for each of them as this would make the message too long.
Oh yes, I missed it, sorry.
quoted
One more question: why is useful to add? Some people forget uppercases?Upper case is desired but not really mandatory. This was a suggestion put forth to me In one of the reviews. https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/ I can abandon this change if you feel it is not appropriate to put many device specific acronyms in the top level word list.
No strong opinion, but I think the patch is OK. David, Ferruh, opinions?