Thread (8 messages) 8 messages, 3 authors, 2021-09-22

Re: [dpdk-dev] [PATCH v3] net/ice: refine flow priority support in PF

From: Ferruh Yigit <hidden>
Date: 2021-09-16 15:59:12

On 9/8/2021 5:58 AM, Yuying Zhang wrote:
The usage of priority is converse in pipeline mode and
non-pipeline mode. Refine attribute priority support of flow
filter in PF driver. When priority is 0, rules are created in
switch filter first and FDIR is used as backup. When priority
is 1, rules are all created in switch filter. Other filters
don't support priority 1. Value 0 denotes higher priority.
Hi Yuying,

Can you please describe the impact of the change more?

Was the usage of the priority wrong either in pipeline or non-pipeline mode
previously?
If so this is a fix patch and we need fixes line, and consider backporting options.

And what is the impact to the user, if we don't have this patch, what user
observes? And what is changed for user after this patch?
Signed-off-by: Yuying Zhang <redacted>
---
v3:
* Fix priority issue of FDIR in pipeline mode. Refine the priority validation.
v2:
* Replace magic number with marco and add comments to explain the calculation.
---
 drivers/net/ice/ice_acl_filter.c    |  5 ++++-
 drivers/net/ice/ice_fdir_filter.c   |  6 +++++-
 drivers/net/ice/ice_generic_flow.c  |  4 ++--
 drivers/net/ice/ice_hash.c          |  5 ++++-
 drivers/net/ice/ice_switch_filter.c | 11 +++++++++--
 5 files changed, 24 insertions(+), 7 deletions(-)
<...>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help