Re: [dpdk-dev] [PATCH 4/4] security: add reserved bitfields
From: Ananyev, Konstantin <hidden>
Date: 2021-09-15 15:55:08
quoted hunk ↗ jump to hunk
In struct rte_security_ipsec_sa_options, for every new option added, there is an ABI breakage, to avoid, a reserved_opts bitfield is added to for the remaining bits available in the structure. Now for every new sa option, these reserved_opts can be reduced and new option can be added. A corresponding exception is also added in devtools/libabigail.abignore Signed-off-by: Akhil Goyal <redacted> --- devtools/libabigail.abignore | 4 ++++ lib/security/rte_security.h | 6 ++++++ 2 files changed, 10 insertions(+)diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 93158405e0..5d8da28e55 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore@@ -52,3 +52,7 @@ ; https://sourceware.org/bugzilla/show_bug.cgi?id=28060 [suppress_type] name = rte_eth_dev_data + +; Ignore changes in reserved_opts bitfield of rte_security_ipsec_sa_options +[suppress_variable] + name = reserved_optsdiff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index 88d31de0a6..4606425e8d 100644 --- a/lib/security/rte_security.h +++ b/lib/security/rte_security.h@@ -181,6 +181,12 @@ struct rte_security_ipsec_sa_options { * * 0: Disable per session security statistics collection for this SA. */ uint32_t stats : 1; + + /** Reserved bit fields for future extension + * + * Note: reduce number of bits in reserved_opts for every new option + */ + uint32_t reserved_opts : 24; }; /** IPSec security association direction */ --
Acked-by: Konstantin Ananyev <redacted>
2.25.1