Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info
From: Ferruh Yigit <hidden>
Date: 2021-09-14 15:53:06
On 8/31/2021 5:12 PM, Andrew Rybchenko wrote:
quoted hunk ↗ jump to hunk
From: Viacheslav Galaktionov <redacted> Make it simpler to debug configurations and code related to the representor info API. Signed-off-by: Viacheslav Galaktionov <redacted> Signed-off-by: Andrew Rybchenko <redacted> Reviewed-by: Andy Moreton <redacted> --- v2: - change output format to log just one line per range app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 135 insertions(+)diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc751..ae700f9dd1 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c@@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result, " Show port supported ptypes" " for a specific port\n\n" + "show port (port_id) representor info\n" + " Show supported representors" + " for a specific port\n\n" +
What do you think extending existing "show port info #" command instead of creating a new command for it? Since "show port info #" is a well known command, it can simplify the usage. When port is representor port it can display additional info.