Re: [dpdk-dev] [PATCH v2 1/6] eal: reset lcore function pointer and argument

On Fri, Sep 10, 2021 at 9:49 AM Bruce Richardson
[off-list ref] wrote:

On Thu, Sep 09, 2021 at 06:13:07PM -0500, Honnappa Nagarahalli wrote:

quoted

In the rte_eal_remote_launch function, the lcore function pointer is
checked for NULL. However, the pointer is never reset to NULL. Reset the
lcore function pointer and argument after the worker has completed
executing the lcore function.

No problems with this patch, but just in general observation.  It would be
good if we had test cases to cover these sorts of problems. If a test were
added to the autotests for this issue we could observe the issue reproduced
and easily verify it were fixed by this patch, giving us a high degree of
confidence in the fix.

+1


-- 
David Marchand