On 8/30/2021 10:41 AM, David Marchand wrote:

Hi Ferruh,

On Fri, Aug 27, 2021 at 3:26 AM Ferruh Yigit [off-list ref] wrote:

quoted

Add 'RTE_ETH' namespace to all enums & macros in a backward compatible

For completeness, there are some struct renames too in this patch.

ack, will add to the commit log. Also fixing some checkpatch warnings and noting
this in the commit log.

quoted

way. The macros for backward compatibility can be removed in next LTS.

Olivier had provided a script when he prefixed librte_net macros.
https://inbox.dpdk.org/dev/20190529144602.5tpfb5p3yasz3tvl@platinum/

Did you use a script to do those renames and can you share it?
Or maybe we can simply reuse Olivier script.

Using Olivier script seems was good idea, but unfortunately I updated manually.

quoted

Internal components switched to new enum & macro names.

I found remaining references for macros and structs.
Enums look fine.

Thanks for catching these, I am updating patch to fix them.

With this patch applied:

# For structs:
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-struct
/ {print $2}' |sort -u); do git grep -w $word |grep -v '#define
'$word'[[:space:]]'; done
lib/ethdev/rte_ethdev.h:    struct rte_fdir_conf fdir_conf; /**< FDIR
configuration. DEPRECATED */
lib/ethdev/rte_ethdev.h:    struct rte_intr_conf intr_conf; /**<
Interrupt mode configuration. */

# Enums look fine:
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-enum /
{print $2}' |sort -u); do git grep -w $word |grep -v '#define
'$word'[[:space:]]'; done
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk
'/^-\t(RTE|ETH)_[^ ,]*,/ {print $2}' |sort -u); do word=${word%%,};
git grep -w $word |grep -v '#define '$word'[[:space:]]'; done
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk
'/^-\t(RTE|ETH)_[^ ,]* = / {print $2}' |sort -u); do git grep -w $word
|grep -v '#define '$word'[[:space:]]'; done

# For macros:
$ for word in $(git show -- 'lib/ethdev/rte_ethdev.h' |awk '/^-#define
/ {print $2}' |sort -u); do git grep -w $word |grep -v '#define
'$word'[[:space:]]' && echo; done
doc/guides/rel_notes/release_18_11.rst:  To request keeping CRC,
application should set ``DEV_RX_OFFLOAD_KEEP_CRC``

doc/guides/rel_notes/release_19_11.rst:  * Added new Rx offload flag
``DEV_RX_OFFLOAD_RSS_HASH`` which can be used to

lib/ethdev/rte_ethdev.h:    } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS];
lib/ethdev/rte_ethdev.h:    } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS];
lib/ethdev/rte_ethdev.h:    uint8_t tc_bws[ETH_DCB_NUM_TCS]; /**< TX
BW percentage for each TC */

lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES];
lib/ethdev/rte_ethdev.h:    uint8_t
prio_tc[ETH_DCB_NUM_USER_PRIORITIES]; /**< Priority to tc */

[snipped the rest of the output] etc...