Re: [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version
From: Dmitry Kozlyuk <hidden>
Date: 2021-08-11 21:55:23
2021-08-05 17:48 (UTC+0000), William Tu:
When OVS inits, it calls rte_version to get the DPDK's version. The patch fixes the error below by exposing rte_version symbol. libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol rte_version referenced in function dpdk_init
Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
Signed-off-by: William Tu <redacted>
Acked-by: Dmitry Kozlyuk <redacted>
quoted hunk ↗ jump to hunk
--- lib/eal/version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/lib/eal/version.map b/lib/eal/version.map index 887012d02a..3de59910cd 100644 --- a/lib/eal/version.map +++ b/lib/eal/version.map@@ -198,7 +198,7 @@ DPDK_21 { rte_uuid_is_null; # WINDOWS_NO_EXPORT rte_uuid_parse; # WINDOWS_NO_EXPORT rte_uuid_unparse; # WINDOWS_NO_EXPORT - rte_version; # WINDOWS_NO_EXPORT + rte_version; rte_vfio_clear_group; # WINDOWS_NO_EXPORT rte_vfio_container_create; # WINDOWS_NO_EXPORT rte_vfio_container_destroy; # WINDOWS_NO_EXPORT
I can see many functions not exported on Windows for no reason. This includes the rest of the version API, but it's experimental, so it's better to have this standalone patch for backporting (since the patch it fixes is backported). I'm going to restore other exports in a bulk patchset.