Re: [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs
From: Akhil Goyal <hidden>
Date: 2021-08-11 08:19:46
From: Akhil Goyal <hidden>
Date: 2021-08-11 08:19:46
From: Akhil Goyalquoted
Some of the cryptodev APIs are not allowed to be used by application directly. Hence removing the usage of 1. queue_pair_release: it is not required, as configure of queue pair release the previous queue pairs and the dev is not directly exposed to application, hence cannot use its ops from app. 2. rte_cryptodev_stop: it can be used directly without checking if the device is started or not. 3. rte_cryptodev_pmd_destroy: application should use rte_cryptodev_close instead. Signed-off-by: Akhil Goyal <redacted>Look's like it should be backported to stable releases with a Fixes reference. What do you think? Besides, Acked-by: Matan Azrad <redacted>
Yes, Agreed. I wanted to get opinion from the Maintainer of fips app first if the changes are Correct or not.