Thread (62 messages) 62 messages, 10 authors, 2021-10-11

Re: [dpdk-dev] [RFC] ethdev: change queue release callback

From: Ferruh Yigit <hidden>
Date: 2021-08-09 15:32:30

On 8/9/2021 3:39 PM, Singh, Aman Deep wrote:
Hi Xueming,

On 7/28/2021 1:10 PM, Andrew Rybchenko wrote:
quoted
On 7/27/21 6:41 AM, Xueming Li wrote:
quoted
To align with other eth device queue configuration callbacks, change RX
and TX queue release callback API parameter from queue object to device
and queue index.

Signed-off-by: Xueming Li <redacted>
In fact, there is no strong reasons to do it, but I think it is a nice
cleanup to use (dev + queue index) on control path.

Hopefully it will not result in any regressions.
Combined there are 100+ API's for Rx/Tx queue_release that need to be modified
for it.

I believe all regression possibilities here will be caught, in compilation phase
itself.
Same here, it is a good cleanup but there is no strong reason for it.

Since it is all internal, there is no ABI restriction on the patch, and v21.11
will be full ABI break patches, to not cause conflicts with this change, what
would you think to have it on v22.02?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help