Thread (11 messages) 11 messages, 3 authors, 2021-10-15

Re: [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory

From: Thomas Monjalon <hidden>
Date: 2021-08-06 15:43:16

01/06/2021 03:56, Feifei Wang:
From: Phil Yang <redacted>

To make the code easier to maintain, use the absolute path for the
default build_dir to avoid repeatedly calling of readlink.
[...]
quoted hunk ↗ jump to hunk
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
-builds_dir=${DPDK_BUILD_TEST_DIR:-.}
+builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.})
It means that all uses of builds_dir will get the absolute path.
It may have consequences on meson configuration,
and will make outputs and logs longer.

I'm not sure this change is desirable.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help