Thread (6 messages) 6 messages, 5 authors, 2023-06-29

Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

From: Gregory Etelson <hidden>
Date: 2021-08-06 13:57:06

Hello,

The TCP flags bitfield patch complements similar changes
proposed to IPv4 header in  net: announce changes in IPv4 header - Patchwork (dpdk.org)<https://patchwork.dpdk.org/project/dpdk/patch/20210802103834.14263-1-getelson@nvidia.com/>

Regards,
Gregory

From: Andrew Rybchenko <redacted>
Sent: Friday, August 6, 2021 12:03
To: NBU-Contact-Thomas Monjalon <redacted>; Gregory Etelson <redacted>
Cc: dev@dpdk.org; Matan Azrad <redacted>; Raslan Darawsheh <redacted>; Ori Kam <redacted>; Ray Kinsella <redacted>; ajit.khaparde@broadcom.com; jerinj@marvell.com; akhil.goyal@nxp.com; cristian.dumitrescu@intel.com; ferruh.yigit@intel.com; konstantin.ananyev@intel.com; olivier.matz@6wind.com; maxime.coquelin@redhat.com; david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

External email: Use caution opening links or attachments

The patch lacks motivation. Why is the change required? Why is it useful?

On August 5, 2021 18:28:31 Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote:

Nobody rejected this change but there is not enough ack
to make it an accepted announce of change.

02/08/2021 12:42, Gregory Etelson:
Announce change to add a union that will provide byte and bitfield
access to TCP flags.

Signed-off-by: Gregory Etelson <getelson@nvidia.com<mailto:getelson@nvidia.com>>
---
+* net: structure ``rte_tcp_hdr`` will have a union that will provide
+  byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help