Thread (4 messages) 4 messages, 4 authors, 2021-08-03

Re: [dpdk-dev] [dpdk-stable] [PATCH] compress/mlx5: fix level translation in xform API

From: Thomas Monjalon <hidden>
Date: 2021-08-03 12:11:50

01/08/2021 08:13, Matan Azrad:
From: Raja Zidane
quoted
Compression Level is interpreted by each PMD differently.
However, lower numbers give faster compression at the expense of
compression ratio, while higher numbers may give better compression ratios
but are likely slower.
The level affects the block size, which affects performance, the bigger the
block, the faster the compression is.

The problem was that higher levels caused bigger blocks:
  size = min_block_size - 1 + level.

the solution is to reverse the above:
  size = max_block_size + 1 - level.

Fixes: 39a2c8715f8f ("compress/mlx5: add transformation operations")
Cc: matan@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Raja Zidane <redacted>
Congrats on your first patch, Raja!
The explanation above is very clear, thank you and
congratulations!
Acked-by: Matan Azrad <redacted>
Applied, thanks.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help