Re: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create
From: Ruifeng Wang <hidden>
Date: 2021-08-03 05:54:46
quoted hunk ↗ jump to hunk
-----Original Message----- From: Honnappa Nagarahalli <redacted> Sent: Saturday, July 31, 2021 5:45 AM To: dev@dpdk.org; Honnappa Nagarahalli [off-list ref]; olivier.matz@6wind.com; lucp.at.work@gmail.com; david.marchand@redhat.com; thomas@monjalon.net Cc: Ruifeng Wang <redacted>; nd <redacted> Subject: [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create The current expected behaviour of the function rte_ctrl_thread_create is rigid which makes the implementation of the function complex. Make the expected behaviour abstract to allow for simplified implementation. With this change, the calls to pthread_setaffinity_np can be moved to the control thread. This will avoid the use of pthread_barrier_wait and simplify the synchronization mechanism between rte_ctrl_thread_create and the calling thread. Signed-off-by: Honnappa Nagarahalli <redacted> --- Possible patch is at: http://patches.dpdk.org/project/dpdk/patch/20210730213709.19400-1- honnappa.nagarahalli@arm.com/ doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/doc/guides/rel_notes/deprecation.rstb/doc/guides/rel_notes/deprecation.rst index 9584d6bfd7..1960e3c8bf 100644--- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst@@ -11,6 +11,13 @@ here. Deprecation Notices ------------------- +* eal: The expected behaviour of the function +``rte_ctrl_thread_create`` + abstracted to allow for simplified implementation. The new behaviour +is + as follows: + Creates a control thread with the given name. The affinity of the new + thread is based on the CPU affinity retrieved at the time +rte_eal_init() + was called, the dataplane and service lcores are then excluded. + * kvargs: The function ``rte_kvargs_process`` will get a new parameter for returning key match count. It will ease handling of no-match case. --2.17.1
Acked-by: Ruifeng Wang <redacted>