Re: [dpdk-dev] [PATCH] net/mlx5: fix timestamp initialization on empty clock queue

Hi,

-----Original Message-----
From: Slava Ovsiienko <redacted>
Sent: Wednesday, July 28, 2021 5:24 PM
To: dev@dpdk.org
Cc: Raslan Darawsheh <redacted>; Matan Azrad
[off-list ref]; stable@dpdk.org
Subject: [PATCH] net/mlx5: fix timestamp initialization on empty clock queue

The committing completions by clock queue might be delayed
after queue initialization done and the only Clock Queue

Added missing auxiliary verb in the syntax,
Should be after queue initialization is done.

completion entry (CQE) might keep the invalid status till
the CQE first update happens.

The mlx5_txpp_update_timestamp() wrongly recognized invalid
status as error and reported about lost synchronization.

The patch recognizes the invalid status as "not updated yet"
and accurate scheduling initialization routine waits till
CQE first update happens.

Some collateral typos in comment are fixed as well.

Fixes: 77522be0a56d ("net/mlx5: introduce clock queue service routine")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <redacted>
---
 drivers/net/mlx5/mlx5_txpp.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh