Re: [dpdk-dev] [PATCH] net/softnic: fix null pointer dereference
From: Singh, Jasvinder <hidden>
Date: 2021-07-27 09:16:39
-----Original Message-----
From: Yu, DapengX <redacted>
Sent: Tuesday, July 27, 2021 9:15 AM
To: Singh, Jasvinder <redacted>; Dumitrescu, Cristian
[off-list ref]
Cc: dev@dpdk.org; Yu, DapengX <redacted>; stable@dpdk.org
Subject: [PATCH] net/softnic: fix null pointer dereference
From: Dapeng Yu <redacted>
When there is no "firmware" in arguments, the "firmware" pointer is null,
and will be dereferenced by rte_strscpy().
This patch moves the code block which copies character string from
"firmware" to "p->firmware" into the "if" statements where "firmware"
argument exists and it is duplicated successfully.
Coverity issue: 372136
Fixes: d8f852f5f369 ("net/softnic: fix memory leak in arguments parsing")
Cc: stable@dpdk.org
Signed-off-by: Dapeng Yu <redacted>
---Acked-by: Jasvinder Singh <redacted>