Thread (4 messages) 4 messages, 3 authors, 2021-07-28

Re: [dpdk-dev] [PATCH] vhost: fix crash on reconnect

From: Wang, Yinan <hidden>
Date: 2021-07-26 08:13:33

Tested-by: Yinan Wang <redacted>

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Maxime Coquelin <redacted>
Sent: 2021?7?26? 15:58
To: dev@dpdk.org; Xia, Chenbo <redacted>; Wang, Yinan
[off-list ref]; Ling, WeiX [off-list ref]
Cc: Maxime Coquelin <redacted>; stable@dpdk.org
Subject: [PATCH] vhost: fix crash on reconnect

When the vhost-user frontend like Virtio-user tries to
reconnect to the restarted Vhost backend, the Vhost backend
segfaults when multiqueue is enabled.

This is caused by VHOST_USER_GET_VRING_BASE being called for
a virtqueue that has not been created before, causing a NULL
pointer dereferencing.

This patch adds the VHOST_USER_GET_VRING_BASE requests to
the list of requests that trigger queue pair allocations.

Fixes: 160cbc815b41 ("vhost: remove a hack on queue allocation")
Cc: stable@dpdk.org

Reported-by: Yinan Wang <redacted>
Signed-off-by: Maxime Coquelin <redacted>
---
 lib/vhost/vhost_user.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 433f412fa8..29a4c9af60 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2796,6 +2796,7 @@ vhost_user_check_and_alloc_queue_pair(struct
virtio_net *dev,
 		break;
 	case VHOST_USER_SET_VRING_NUM:
 	case VHOST_USER_SET_VRING_BASE:
+	case VHOST_USER_GET_VRING_BASE:
 	case VHOST_USER_SET_VRING_ENABLE:
 		vring_idx = msg->payload.state.index;
 		break;
--
2.31.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help