Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver
From: Xia, Chenbo <hidden>
Date: 2021-07-26 05:56:25
Hi, Ferruh
-----Original Message----- From: Yigit, Ferruh <redacted> Sent: Friday, July 23, 2021 8:47 PM To: Xia, Chenbo <redacted>; dev@dpdk.org; thomas@monjalon.net Cc: mdr@ashroe.eu; nhorman@tuxdriver.com; david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver On 7/23/2021 8:39 AM, Xia, Chenbo wrote:quoted
Hi, A gentle ping for comments..quoted
-----Original Message----- From: dev <redacted> On Behalf Of Chenbo Xia Sent: Tuesday, June 1, 2021 4:42 PM To: dev@dpdk.org; thomas@monjalon.net Cc: mdr@ashroe.eu; nhorman@tuxdriver.com Subject: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI busdriverquoted
quoted
All ABIs in PCI bus driver, which are defined in rte_buc_pci.h, will be removed and the header will be made internal. Signed-off-by: Chenbo Xia <redacted> --- doc/guides/rel_notes/deprecation.rst | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/doc/guides/rel_notes/deprecation.rstb/doc/guides/rel_notes/deprecation.rst index 9584d6bfd7..b01f46c62e 100644--- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst@@ -147,3 +147,8 @@ Deprecation Notices * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific content. On Linux and FreeBSD, supported prior to DPDK 20.11, original structure will be kept until DPDK 21.11. + +* pci: To reduce unnecessary ABIs exposed by DPDK bus driver,"rte_bus_pci.h"quoted
quoted
+ will be made internal in 21.11 and macros/data structures/functionsdefinedquoted
quoted
+ in the header will not be considered as ABI anymore. This change is inspired + by the RFChttps://patchwork.dpdk.org/project/dpdk/list/?series=17176.quoted
I see there's some ABI improvement work on-going and I think it could bepart ofquoted
the work. If it makes sense to you, I'd like some ACKs.Acked-by: Ferruh Yigit <redacted> I am for reducing the public ABI as much as possible. How big will the change be? Is the 'rte_bus_pci.h' used other than './drivers/bus/pci/'?
I don't see big change here. And I am not sure if I understand your second question. The rte_bus_pci.h will still be used by drivers (maybe remove the rte prefix and change the file name). Thanks, Chenbo