-----Original Message-----
From: Anoob Joseph <redacted>
Sent: Tuesday, July 20, 2021 11:16 AM
To: Akhil Goyal <redacted>; Declan Doherty
[off-list ref]; Fan Zhang [off-list ref];
Konstantin Ananyev [off-list ref]
Cc: Anoob Joseph <redacted>; Jerin Jacob Kollanukkaran
[off-list ref]; Ankur Dwivedi [off-list ref]; Tejasree
Kondoj [off-list ref]; dev@dpdk.org
Subject: [PATCH 2/2] lib/security: add SA lifetime configuration

Add SA lifetime configuration to register soft and hard expiry limits.
Expiry can be in units of number of packets or bytes. Crypto op status is also
updated to cover warnings indicating soft expiry in case of lookaside protocol
operations.

In case of soft expiry, the packets are successfully IPsec processed but the
soft expiry would indicate that SA needs to be reconfigured. For inline
protocol capable ethdev, this would result in an eth event while for lookaside
protocol capable cryptodev, this can be communicated via
`rte_crypto_op.status` field.

In case of hard expiry, the packets will not be IPsec processed and would
result in error.

Signed-off-by: Anoob Joseph <redacted>
---
 examples/ipsec-secgw/ipsec.c |  2 +-
 examples/ipsec-secgw/ipsec.h |  2 +-
 lib/cryptodev/rte_crypto.h   |  7 +++++++
 lib/security/rte_security.h  | 28 ++++++++++++++++++++++++++--
 4 files changed, 35 insertions(+), 4 deletions(-)

diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index 5b032fe..4868294 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c

@@ -49,7 +49,7 @@ set_ipsec_conf(struct ipsec_sa *sa, struct

rte_security_ipsec_xform *ipsec)
 		}
 		/* TODO support for Transport */
 	}
-	ipsec->esn_soft_limit = IPSEC_OFFLOAD_ESN_SOFTLIMIT;
+	ipsec->life.packets_soft_limit = IPSEC_OFFLOAD_PKTS_SOFTLIMIT;
 	ipsec->replay_win_sz = app_sa_prm.window_size;
 	ipsec->options.esn = app_sa_prm.enable_esn;
 	ipsec->options.udp_encap = sa->udp_encap; diff --git
a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h index
ae5058d..90c81c1 100644

--- a/examples/ipsec-secgw/ipsec.h
+++ b/examples/ipsec-secgw/ipsec.h

@@ -23,7 +23,7 @@

 #define MAX_DIGEST_SIZE 32 /* Bytes -- 256 bits */

-#define IPSEC_OFFLOAD_ESN_SOFTLIMIT 0xffffff00
+#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00

 #define IV_OFFSET		(sizeof(struct rte_crypto_op) + \
 				sizeof(struct rte_crypto_sym_op))

diff --git a/lib/cryptodev/rte_crypto.h b/lib/cryptodev/rte_crypto.h index

fd5ef3a..c5a0897 100644

--- a/lib/cryptodev/rte_crypto.h
+++ b/lib/cryptodev/rte_crypto.h

@@ -52,6 +52,13 @@ enum rte_crypto_op_status {
 	/**< Operation failed due to invalid arguments in request */
 	RTE_CRYPTO_OP_STATUS_ERROR,
 	/**< Error handling operation */
+	RTE_CRYPTO_OP_STATUS_WAR = 128,
+	/**<
+	 * Operation completed successfully with warnings.
+	 * Note: All the warnings starts from here.
+	 */
+	RTE_CRYPTO_OPSTATUS_WAR_SOFT_EXPIRY,
+	/**< Operation completed successfully with soft expiry of lifetime */
 };

 /**

diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index

d61a55d..d633c8d 100644

--- a/lib/security/rte_security.h
+++ b/lib/security/rte_security.h

@@ -206,6 +206,30 @@ enum rte_security_ipsec_sa_direction {  };

 /**
+ * Configure soft and hard lifetime of an IPsec SA
+ *
+ * Lifetime of an IPsec SA would specify the maximum number of packets
+or bytes
+ * that can be processed. IPsec operations would start failing once any
+hard
+ * limit is reached.
+ *
+ * Soft limits can be specified to generate notification when the SA is
+ * approaching hard limits for lifetime. For inline operations,
+reaching soft
+ * expiry limit would result in raising an eth event for the same. For
+lookaside
+ * operations, this would result in a warning returned in
+ * ``rte_crypto_op.status``.
+ */
+struct rte_security_ipsec_lifetime {
+	uint64_t packets_soft_limit;
+	/**< Soft expiry limit in number of packets */
+	uint64_t bytes_soft_limit;
+	/**< Soft expiry limit in bytes */
+	uint64_t packets_hard_limit;
+	/**< Soft expiry limit in number of packets */
+	uint64_t bytes_hard_limit;
+	/**< Soft expiry limit in bytes */
+};
+
+/**
  * IPsec security association configuration data.
  *
  * This structure contains data required to create an IPsec SA security

session.

@@ -225,8 +249,8 @@ struct rte_security_ipsec_xform {
 	/**< IPsec SA Mode - transport/tunnel */
 	struct rte_security_ipsec_tunnel_param tunnel;
 	/**< Tunnel parameters, NULL for transport mode */
-	uint64_t esn_soft_limit;
-	/**< ESN for which the overflow event need to be raised */
+	struct rte_security_ipsec_lifetime life;
+	/**< IPsec SA lifetime */
 	uint32_t replay_win_sz;
 	/**< Anti replay window size to enable sequence replay attack

handling.
 	 * replay checking is disabled if the window size is 0.
--
2.7.4