Re: [dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe

On Mon, 19 Jul 2021 10:15:34 -0700
Tyler Retzlaff [off-list ref] wrote:

On Tue, Jul 13, 2021 at 01:12:21PM -0700, Stephen Hemminger wrote:

quoted

The first argument to rte_bsf32_safe was incorrectly declared as
a 64 bit value. This function only correctly handles on 32 bit values
and the underlying function rte_bsf32 only accepts 32 bit values.
This was introduced when the safe version was added and probably cause
by copy/paste from the 64 bit version.  

there are multiple errors in this family of functions [1] both in usage
and signatures. we previously discussed rolling all fixes up into a single
patch and announcing an api break.

a doc patch was submitted as per the process documented for breaking api
but received no replies [2]

i have a full patch that corrects the whole family if you would like to
take it instead. contact me offline if you are interested.

1. http://mails.dpdk.org/archives/dev/2021-March/201590.html
2. http://mails.dpdk.org/archives/dev/2021-March/201868.html

the change stand-alone is correct so

Acked-By: Tyler Retzlaff <redacted>

Thanks, I think the larger set should go into 21.11 where API/ABI break
would be ok. My bit was all about fixing the bug where current code
breaks C++ users.