Thread (50 messages) 50 messages, 7 authors, 2021-07-21

Re: [dpdk-dev] [PATCH v5 1/4] examples/vhost: refactor vhost enqueue and dequeue datapaths.

From: Maxime Coquelin <hidden>
Date: 2021-07-13 13:35:05

Hi Wenwu,

Please do not add dot in the commit title.

On 7/5/21 8:11 PM, Wenwu Ma wrote:
Previously, by judging the flag, we call different enqueue/dequeue
functions in data path.

Now, we use an ops that was initialized when Vhost was created,
so that we can call ops directly in Vhost data path without any more
flag judgment.

Signed-off-by: Wenwu Ma <redacted>
---
 examples/vhost/main.c       | 112 ++++++++++++++++++++----------------
 examples/vhost/main.h       |  33 +++++++++--
 examples/vhost/virtio_net.c |  16 +++++-
 3 files changed, 105 insertions(+), 56 deletions(-)
Other than that, it looks good to me.
The typo in the title can be fixed while applying:

Reviewed-by: Maxime Coquelin <redacted>

Thanks,
Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help