Re: [dpdk-dev] [PATCH v2] net/bnxt: fix missing barriers in completion handling
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: 2021-07-12 21:44:11
On Sun, Jul 11, 2021 at 7:34 PM Ruifeng Wang [off-list ref] wrote:
quoted
-----Original Message----- From: Lance Richardson <redacted> Sent: Saturday, July 10, 2021 12:39 AM To: Ajit Khaparde (ajit.khaparde@broadcom.com) [off-list ref]; Somnath Kotur [off-list ref]; Bruce Richardson [off-list ref]; Konstantin Ananyev [off-list ref]; jerinj@marvell.com; Ruifeng Wang [off-list ref]; Stephen Hurd [off-list ref]; David Christensen [off-list ref] Cc: dev@dpdk.org; stable@dpdk.org Subject: [PATCH v2] net/bnxt: fix missing barriers in completion handling Ensure that Rx/Tx/Async completion entry fields are accessed only after the completion's valid flag has been loaded and verified. This is needed for correct operation on systems that use relaxed memory consistency models. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: stable@dpdk.org Signed-off-by: Lance Richardson <redacted> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- v2: * Corrected name of the first parameter to bnxt_cpr_cmp_valid() in comments ('cmp' to 'cmpl'). drivers/net/bnxt/bnxt_cpr.h | 36 ++++++++++++++++++++++++--- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++------ drivers/net/bnxt/bnxt_irq.c | 7 +++--- drivers/net/bnxt/bnxt_rxr.c | 9 ++++--- drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 2 +- drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 2 +- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +- drivers/net/bnxt/bnxt_txr.c | 2 +- 8 files changed, 54 insertions(+), 22 deletions(-)Reviewed-by: Ruifeng Wang <redacted>
Patch applied to dpdk-next-net-brcm. Thanks