Thread (7 messages) 7 messages, 3 authors, 2021-07-10

Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power

From: Thomas Monjalon <hidden>
Date: 2021-07-10 06:44:01

23/06/2021 16:14, Burakov, Anatoly:
On 23-Jun-21 1:09 PM, David Hunt wrote:
quoted
On 23/6/2021 11:14 AM, Burakov, Anatoly wrote:
quoted
On 22-Jun-21 3:07 PM, David Hunt wrote:
quoted
The PMD Power Management scheme currently has 3 modes,
scale, monitor and pause. However, it would be nice to
have a baseline mode for easy comparison of power savings
with and without these modes.

This patch adds a 'baseline' mode were the pmd power
management is not enabled. Use --pmg-mgmt=baseline.

Signed-off-by: David Hunt <redacted>

---
  -            if (app_mode == APP_MODE_PMD_MGMT) {
+            if ((app_mode == APP_MODE_PMD_MGMT) &&
+                    (baseline_enabled == false)) {
Nitpicking, !baseline_enabled
Thanks, Anatoly. I don't feel a re-spin is needed for this, but I'll 
take this format into consideration for future patches, OK?
Yep, i'm fine either way. Maybe someone can fix it on apply :)
Applied with the change.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help