Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58
From: Thomas Monjalon <hidden>
Date: 2021-07-09 12:49:57
01/07/2021 11:57, Bruce Richardson:
On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote:quoted
On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote:quoted
The `doc` target used `echo` as its command. On Windows, `echo` is always a shell built-in, there is no binary. Starting from meson 0.58, `run_target()` always searches for command executable and no longer accepts `echo` as such on Windows. Replace plain `echo` with a Python one-liner. Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson") Cc: Bruce Richardson <redacted> Cc: Luca Boccassi <redacted> Cc: stable@dpdk.org Reported-by: Rob Scheepens <redacted> Signed-off-by: Dmitry Kozlyuk <redacted> ---Acked-by: Luca Boccassi <redacted>One small suggestion might be to move the "echo" command definition to buildtools folder in case it's wanted for use anywhere in the build at some point in the future. However, this patch is fine without that change too.
I did the move in buildtools/meson.build: echo = py3 + ['-c', 'import sys; print(*sys.argv[1:])']
Acked-by: Bruce Richardson <redacted>
Acked-by: Thomas Monjalon <redacted> Applied, thanks