Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK
From: Lin, Xueqin <hidden>
Date: 2021-07-02 11:05:23
-----Original Message----- From: David Marchand <redacted> Sent: Thursday, July 1, 2021 3:41 PM To: Lin, Xueqin <redacted>; Burakov, Anatoly [off-list ref] Cc: Jerin Jacob <redacted>; Peng, ZhihongX [off-list ref]; Ananyev, Konstantin [off-list ref]; Stephen Hemminger [off-list ref]; dpdk-dev [off-list ref] Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK On Thu, Jul 1, 2021 at 8:48 AM Lin, Xueqin [off-list ref] wrote:quoted
We also captured this type issues and selected one, reported in internalsystem JARA and bugzilla in May.quoted
Pls check https://bugs.dpdk.org/show_bug.cgi?id=722 for detail, somedevelopers are analysis this issue in JIRA but not resolved so far, Anatoly should also know this. Thanks for sharing this.quoted
It is DPDK issue, not this patch issue, it doesn't mean we not do much test. We put all of thousands of regression cases as case list for this patch test,some issues still are tracking. Sorry, can you rephrase? I sure hope there are not thousands of issues with ASAN.
Relax, don't have so many issues. I mean we have thousands of automation dpdk cases, run the cases for DPDK version build with Asan tool, check dpdk code if have memory issue. Some issues are still WIP to check.
Are all identified issues reported in dpdk.org bugzilla? It would help to have a hint in the bzs title, like "caught with ASAN".
No, we reported common issue to Bugzilla. Good idea to add title.
I can't find a report about the infinite loop on invalid fds, making a dpdk app unable to exit gracefully with ASAN enabled. But at least, I sent a fix for this, waiting for Anatoly to review. https://patchwork.dpdk.org/project/dpdk/patch/20210614091213.3953-1- david.marchand@redhat.com/quoted
quoted
Anyway, the memory allocator is your stuff, so your call. Prefix for the title of such a patch should be mem:Anatoly and Jerin like your patch, but it is still a RFC and there were comments on a missing release note update and unit test. Please address those comments and submit a regular patch.
Sure, we are preparing the v1 patch according to comment.
Thanks. -- David Marchand