Re: [dpdk-dev] [PATCH] app/eventdev: remove unnecessary barrier for order test
From: Jerin Jacob <hidden>
Date: 2021-06-30 06:49:42
On Mon, May 10, 2021 at 11:42 AM Feifei Wang [off-list ref] wrote:
For "order_launch_lcores" function, wmb after that the main lcore updates the variable "t->err", which represents the end of the test signal, is unnecessary. Because after the main lcore updates this siginal variable, it will jump out of the launch function loop, and wait other lcores stop or return error in the main function(evt_main.c). During this time, there is no storing operation and thus no need for wmb. Signed-off-by: Feifei Wang <redacted> Reviewed-by: Ruifeng Wang <redacted> Reviewed-by: Honnappa Nagarahalli <redacted>
Acked-by: Jerin Jacob <redacted> Applied to dpdk-next-net-eventdev/for-main. Thanks
quoted hunk ↗ jump to hunk
--- app/test-eventdev/test_order_common.c | 1 - 1 file changed, 1 deletion(-)diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c index 04456d56db..d7760061ba 100644 --- a/app/test-eventdev/test_order_common.c +++ b/app/test-eventdev/test_order_common.c@@ -308,7 +308,6 @@ order_launch_lcores(struct evt_test *test, struct evt_options *opt, rte_event_dev_dump(opt->dev_id, stdout); evt_err("No schedules for seconds, deadlock"); t->err = true; - rte_smp_wmb(); break; } old_remaining = remaining; --2.25.1