Re: [dpdk-dev] [PATCH] test/crypto: fix autotest function parameters
From: Power, Ciara <hidden>
Date: 2021-06-29 14:32:22
Hi Rebecca, Looks good, thanks. One minor change added inline below. With this change, Acked-by: Ciara Power <redacted>
-----Original Message-----
From: Troy, Rebecca <redacted>
Sent: Monday 28 June 2021 17:15
To: dev@dpdk.org
Cc: Power, Ciara <redacted>; Troy, Rebecca
[off-list ref]; Doherty, Declan [off-list ref];
jianjay.zhou@huawei.com; De Lara Guarch, Pablo
[off-list ref]; Zhang, Roy Fan
[off-list ref]; akhil.goyal@nxp.com;
hemant.agrawal@nxp.com; stable@dpdk.org
Subject: [PATCH] test/crypto: fix autotest function parameters
Fixed parameters on autotest functions by removing comments.
Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Fixes: 4ed1e79e7819 ("test/crypto: add tests for virtio-crypto")
Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library")
Fixes: 27a1c4714d54 ("app/test: add KASUMI crypto")
Fixes: 4c99481f49c4 ("app/test: add ZUC")
Fixes: c8e69fce7046 ("crypto/scheduler: add unit test")
Fixes: ae002048bbea ("test/crypto: add DPAA2 crypto functional test")
Fixes: b674d6d0381a ("test/crypto: add dpaa crypto test cases")
Fixes: a8dbd44d6b4c ("test/crypto: add CAAM JR validation cases")
Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
Cc: declan.doherty@intel.com
Cc: jianjay.zhou@huawei.com
Cc: pablo.de.lara.guarch@intel.com
Cc: roy.fan.zhang@intel.com
Cc: akhil.goyal@nxp.comThis should be updated to Akhil's new email address (cc'd): [off-list ref]
quoted hunk ↗ jump to hunk
Cc: hemant.agrawal@nxp.com Cc: stable@dpdk.org Signed-off-by: Rebecca Troy <redacted> --- app/test/test_cryptodev.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index39db52b17a..c18730f138 100644--- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c@@ -14521,19 +14521,19 @@ run_cryptodev_testsuite(const char*pmd_name) } static int -test_cryptodev_qat(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_qat(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)); } static int -test_cryptodev_virtio(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_virtio(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_VIRTIO_PMD)); } static int -test_cryptodev_aesni_mb(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_aesni_mb(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_AESNI_MB_PMD)); }@@ -14579,19 +14579,19 @@ test_cryptodev_null(void) }static int -test_cryptodev_sw_snow3g(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_sw_snow3g(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_SNOW3G_PMD)); } static int -test_cryptodev_sw_kasumi(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_sw_kasumi(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_KASUMI_PMD)); } static int -test_cryptodev_sw_zuc(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_sw_zuc(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_ZUC_PMD)); }@@ -14611,7 +14611,7 @@ test_cryptodev_mrvl(void) #ifdefRTE_CRYPTO_SCHEDULER static int -test_cryptodev_scheduler(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_scheduler(void) { uint8_t ret, sched_i, j, i = 0, blk_start_idx = 0; const enum blockcipher_test_type blk_suites[] = { @@ -14719,13 +14719,13 @@ REGISTER_TEST_COMMAND(cryptodev_scheduler_autotest, test_cryptodev_scheduler); #endif static int -test_cryptodev_dpaa2_sec(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_dpaa2_sec(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD)); } static int -test_cryptodev_dpaa_sec(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_dpaa_sec(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA_SEC_PMD)); }@@ -14749,7 +14749,7 @@ test_cryptodev_octeontx2(void) }static int -test_cryptodev_caam_jr(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_caam_jr(void) { return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_CAAM_JR_PMD)); }@@ -14767,7 +14767,7 @@ test_cryptodev_bcmfs(void) }static int -test_cryptodev_qat_raw_api(void /*argv __rte_unused, int argc __rte_unused*/) +test_cryptodev_qat_raw_api(void) { int ret; -- 2.25.1