Hi Singh:
	This update only provides the capability to match the last 8-bits reserved field of VXLAN header.
	No package modification totally. Package content is up to end user' decision.
BR
Rongwei

-----Original Message-----
From: dev <redacted> On Behalf Of Singh, Aman Deep
Sent: Wednesday, June 16, 2021 1:16 AM
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC 2/2] app/testpmd: support VXLAN last 8-bits
field matching

External email: Use caution opening links or attachments


Hi Rongwei,

As per VxLAN RFC 7348- <https://datatracker.ietf.org/doc/html/rfc7348>

Reserved fields (24 bits and 8 bits): MUST be set to zero on transmission and
ignored on receipt.

I hope this criteria will be met for external packets.

On 5/31/2021 3:49 PM, rongwei liu wrote:

quoted

Add a new testpmd pattern field 'last_rsvd' that supports the last
8-bits matching of VXLAN header.

The examples for the "last_rsvd" pattern field are as below:

1. ...pattern eth / ipv4 / udp / vxlan last_rsvd is 0x80 / end ...

This flow will exactly match the last 8-bits to be 0x80.

2. ...pattern eth / ipv4 / udp / vxlan last_rsvd spec 0x80 vxlan mask
0x80 / end ...

Shouldn't this be as below, (or I am mistaken)-

2. ...pattern eth / ipv4 / udp / vxlan last_rsvd spec 0x80 last_rsvd mask 0x80 /
end ...

quoted

This flow will only match the MSB of the last 8-bits to be 1.

Signed-off-by: rongwei liu <redacted>
---
  app/test-pmd/cmdline_flow.c                 | 9 +++++++++
  app/test-pmd/util.c                         | 5 +++--
  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 1 +
  3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1c587bb7b8..6e76a625ca 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c

@@ -207,6 +207,7 @@ enum index {
      ITEM_SCTP_CKSUM,
      ITEM_VXLAN,
      ITEM_VXLAN_VNI,
+     ITEM_VXLAN_LAST_RSVD,
      ITEM_E_TAG,
      ITEM_E_TAG_GRP_ECID_B,
      ITEM_NVGRE,

@@ -1129,6 +1130,7 @@ static const enum index item_sctp[] = {

  static const enum index item_vxlan[] = {
      ITEM_VXLAN_VNI,
+     ITEM_VXLAN_LAST_RSVD,
      ITEM_NEXT,
      ZERO,
  };

@@ -2806,6 +2808,13 @@ static const struct token token_list[] = {
              .next = NEXT(item_vxlan, NEXT_ENTRY(UNSIGNED), item_param),
              .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan, vni)),
      },
+     [ITEM_VXLAN_LAST_RSVD] = {
+             .name = "last_rsvd",
+             .help = "VXLAN last reserved bits",
+             .next = NEXT(item_vxlan, NEXT_ENTRY(UNSIGNED), item_param),
+             .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan,
+                                          rsvd1)),
+     },
      [ITEM_E_TAG] = {
              .name = "e_tag",
              .help = "match E-Tag header", diff --git

a/app/test-pmd/util.c b/app/test-pmd/util.c index
a9e431a8b2..59626518d5 100644

--- a/app/test-pmd/util.c
+++ b/app/test-pmd/util.c

@@ -266,8 +266,9 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue,

struct rte_mbuf *pkts[],

quoted

                              vx_vni = rte_be_to_cpu_32(vxlan_hdr->vx_vni);
                              MKDUMPSTR(print_buf, buf_size, cur_len,
                                        " - VXLAN packet: packet type =%d, "
-                                       "Destination UDP port =%d, VNI = %d",
-                                       packet_type, udp_port, vx_vni >> 8);
+                                       "Destination UDP port =%d, VNI = %d, "
+                                       "last_rsvd = %d", packet_type,
+                                       udp_port, vx_vni >> 8, vx_vni
+ & 0xff);
                      }
              }
              MKDUMPSTR(print_buf, buf_size, cur_len, diff --git
a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 33857acf54..4ca3103067 100644

--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst

@@ -3694,6 +3694,7 @@ This section lists supported pattern items and

their attributes, if any.

quoted

  - ``vxlan``: match VXLAN header.

    - ``vni {unsigned}``: VXLAN identifier.
+  - ``last_rsvd {unsigned}``: VXLAN last reserved 8-bits.

  - ``e_tag``: match IEEE 802.1BR E-Tag header.