Thread (5 messages) 5 messages, 4 authors, 2021-08-16

Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log

From: Andrew Rybchenko <hidden>
Date: 2021-06-28 11:13:37

Hi Heinrich,

could you take a look at the patch?

Thanks,
Andrew.

On 5/18/21 1:41 PM, Ferruh Yigit wrote:
quoted hunk ↗ jump to hunk
Logging should be converted to dynamic log.

Signed-off-by: Ferruh Yigit <redacted>
---
  drivers/net/nfp/nfp_net_logs.h | 7 -------
  1 file changed, 7 deletions(-)
diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
index 27dd87611b94..76cc94cb6565 100644
--- a/drivers/net/nfp/nfp_net_logs.h
+++ b/drivers/net/nfp/nfp_net_logs.h
@@ -30,14 +30,7 @@ extern int nfp_logtype_init;
  #define ASSERT(x) do { } while (0)
  #endif
  
-#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
-
-#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
-#define PMD_CPP_LOG(level, fmt, args...) \
-	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
-#else
  #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
-#endif
  
  extern int nfp_logtype_driver;
  #define PMD_DRV_LOG(level, fmt, args...) \
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help