Thread (30 messages) 30 messages, 5 authors, 2021-07-08

Re: [dpdk-dev] [PATCH v5 2/2] power: refactor pstate and acpi code

From: David Hunt <hidden>
Date: 2021-06-22 13:28:06

Adding people to the CC list that were on v4 of this patch set, and 
Richael who raised some issues in v4.

On 22/6/2021 1:58 PM, David Hunt wrote:
From: Anatoly Burakov <redacted>

Currently, ACPI and PSTATE modes have lots of code duplication,
confusing logic, and a bunch of other issues that can, and have, led to
various bugs and resource leaks.

This commit factors out the common parts of sysfs reading/writing for
ACPI and PSTATE drivers.

Signed-off-by: Anatoly Burakov <redacted>
Signed-off-by: David Hunt <redacted>

---
changes in v2 (should read v5)
* fixed bugs raised by Richael Zhuang in review - open file rw+, etc.
* removed FOPS* and FOPEN* macros, which contained control statements.
* fixed some checkpatch warnings.

So in the process of posting v5, I picked the email id from v4 in 
patchwork, used that in my --in-reply-to, and somehow it screwed up the 
threading as it looks like I'm responding to v3. So I'm sending this 
email to make sure all the people CC'd in v4 are included in this (v5).

Anatoly is busy at the moment, so I'm addressing the issues raised in 
v4, and additionally adressing the checkpatch issues where it does not 
like the macros with control statements, so removing those, as I don't 
like them either.

Regards,
Dave.



Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help