Re: [dpdk-dev] [PATCH] bus: clarify log for non-NUMA-aware devices
From: Xueming(Steven) Li <hidden>
Date: 2021-06-15 11:08:06
-----Original Message-----
From: Dmitry Kozlyuk <redacted>
Sent: Tuesday, June 15, 2021 6:44 PM
To: dev@dpdk.org
Cc: Xueming(Steven) Li <redacted>; stable@dpdk.org; Marcin Wojtas <redacted>; Michal Krawczyk
[off-list ref]; Guy Tzalik [off-list ref]; Evgeny Schemeilin [off-list ref]; Igor Chauskin
[off-list ref]; Stephen Hemminger [off-list ref]; NBU-Contact-longli [off-list ref]; Sergio
Gonzalez Monroy [off-list ref]
Subject: [PATCH] bus: clarify log for non-NUMA-aware devices
PCI and vmbus drivers printed a warning
when NUMA node had beed reported as (-1) or not reported by OS:
EAL: Invalid NUMA socket, default to 0
This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or
intervention.
Reduce level to INFO and reword the message.
Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe")
Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
Cc: stable@dpdk.org
Signed-off-by: Dmitry Kozlyuk <redacted>
Reviewed-by: Slava Ovsiienko <redacted>
---
Hi Xueming,
Please align logging in the pending bus/auxiliary patch.LGTM, updated.
quoted hunk
doc/guides/nics/ena.rst | 2 +- drivers/bus/pci/pci_common.c | 2 +- drivers/bus/vmbus/vmbus_common.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 0f1f63f722..694ce1da74 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst@@ -234,7 +234,7 @@ Example output: [...] EAL: PCI device 0000:00:06.0 on NUMA socket -1 - EAL: Invalid NUMA socket, default to 0 + EAL: Device is not NUMA-aware, defaulting socket to 0 EAL: probe driver: 1d0f:ec20 net_ena Interactive-mode selecteddiff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 35d7d092d1..bf06f81229 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c@@ -190,7 +190,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, } if (dev->device.numa_node < 0) { - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); + RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to +0\n"); dev->device.numa_node = 0; }diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index d25fd14ef5..ef23af90ec 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c@@ -112,7 +112,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, dev->driver = dr; if (dev->device.numa_node < 0) { - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); + VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to +0\n"); dev->device.numa_node = 0; } --2.18.2
Reviewed-by: Xueming(Steven) Li <redacted>