Re: [dpdk-dev] [PATCH v1 0/8] use GCC's C11 atomic builtins for test
From: David Marchand <hidden>
Date: 2021-06-11 08:41:04
From: David Marchand <hidden>
Date: 2021-06-11 08:41:04
On Fri, Jun 4, 2021 at 11:46 AM Joyce Kong [off-list ref] wrote:
Since C11 memory model is adopted in DPDK now[1], use GCC's atomic builtins in test cases. [1]https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/ Joyce Kong (8): test/ticketlock: use GCC atomic builtins for lcores sync test/spinlock: use GCC atomic builtins for lcores sync test/rwlock: use GCC atomic builtins for lcores sync test/mcslock: use GCC atomic builtins for lcores sync test/mempool: remove unused variable for lcores sync test/mempool_perf: use GCC atomic builtins for lcores sync test/service_cores: use GCC atomic builtins for lock sync test/rcu_perf: use GCC atomic builtins for data sync
Just a nit, use rte_wait_until_equal() instead of those sync loops. Rest lgtm, thanks. -- David Marchand