Thread (3 messages) 3 messages, 2 authors, 2021-06-01

Re: [dpdk-dev] [PATCH] net/iavf: fix error handle for unsupported promisc configure

From: Zhang, Qi Z <hidden>
Date: 2021-06-01 11:07:45

-----Original Message-----
From: Xing, Beilei <redacted>
Sent: Thursday, May 27, 2021 9:54 AM
To: Zhang, Qi Z <redacted>
Cc: dev@dpdk.org; stable@dpdk.org
Subject: RE: [PATCH] net/iavf: fix error handle for unsupported promisc
configure


quoted
-----Original Message-----
From: Zhang, Qi Z <redacted>
Sent: Wednesday, May 26, 2021 5:53 PM
To: Xing, Beilei <redacted>
Cc: dev@dpdk.org; Zhang, Qi Z <redacted>; stable@dpdk.org
Subject: [PATCH] net/iavf: fix error handle for unsupported promisc
configure

iavf_execute_vf_cmd returns standard error code but not IAVF_xxx, The
patch fix the wrong error handling in iavf_config_promisc.

Fixes: 1e4d55a7fe71 ("net/iavf: optimize promiscuous device
operations")
Cc: stable@dpdk.org

Signed-off-by: Qi Zhang <redacted>
---
 drivers/net/iavf/iavf_vchnl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c
b/drivers/net/iavf/iavf_vchnl.c index
5d57e8b541..02e828f9b7 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -1257,8 +1257,8 @@ iavf_config_promisc(struct iavf_adapter *adapter,
 		PMD_DRV_LOG(ERR,
 			    "fail to execute command
CONFIG_PROMISCUOUS_MODE");

-		if (err == IAVF_NOT_SUPPORTED)
-			return -ENOTSUP;
+		if (err == -ENOTSUP)
+			return err;

 		return -EAGAIN;
 	}
--
2.26.2
Acked-by: Beilei Xing <redacted>
Applied to dpdk-next-net-intel.

Thanks
Qi
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help