Thread (3 messages) 3 messages, 3 authors, 2021-05-27

Re: [dpdk-dev] [PATCH v1] net/iavf: fix RSS key access out of index

From: Zhang, Qi Z <hidden>
Date: 2021-05-27 09:51:29

-----Original Message-----
From: Xing, Beilei <redacted>
Sent: Thursday, May 20, 2021 9:24 AM
To: Wang, Haiyue <redacted>; dev@dpdk.org
Cc: Zhang, Qi Z <redacted>; stable@dpdk.org; Wu, Jingjing
[off-list ref]
Subject: RE: [PATCH v1] net/iavf: fix RSS key access out of index


quoted
-----Original Message-----
From: Wang, Haiyue <redacted>
Sent: Wednesday, May 19, 2021 4:00 PM
To: dev@dpdk.org
Cc: Zhang, Qi Z <redacted>; Wang, Haiyue
[off-list ref]; stable@dpdk.org; Wu, Jingjing
[off-list ref]; Xing, Beilei [off-list ref]
Subject: [PATCH v1] net/iavf: fix RSS key access out of index

The array rss_key has size 'vf->vf_res->rss_key_size', the array index
should be less than that.

Cc: stable@dpdk.org
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")

Signed-off-by: Haiyue Wang <redacted>
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c
b/drivers/net/iavf/iavf_ethdev.c index d688c31cfb..cb38fe81e1 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -366,7 +366,7 @@ iavf_init_rss(struct iavf_adapter *adapter)
 	/* configure RSS key */
 	if (!rss_conf->rss_key) {
 		/* Calculate the default hash key */
-		for (i = 0; i <= vf->vf_res->rss_key_size; i++)
+		for (i = 0; i < vf->vf_res->rss_key_size; i++)
 			vf->rss_key[i] = (uint8_t)rte_rand();
 	} else
 		rte_memcpy(vf->rss_key, rss_conf->rss_key,
--
2.31.1
Acked-by: Beilei Xing <redacted>
Applied to dpdk-next-net-intel.

Thanks
Qi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help