Re: [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check
From: Pattan, Reshma <hidden>
Date: 2021-05-11 13:34:43
From: Pattan, Reshma <hidden>
Date: 2021-05-11 13:34:43
-----Original Message----- From: Min Hu (Connor) <redacted>quoted
Another suggestion if you would like to improve the code, is below, You can move "global_fds[lcore_id]" check to immediate after the line"fds.fd = global_fds[lcore_id]; " Hi, thanks Pattan. But I think "global_fds[lcore_id]" check may move before the line "fds.fd = global_fds[lcore_id]; If it failed, "fds.fd = global_fds[lcore_id];" should not be performed. What's your opinion?
That is correct. You can do that change.