Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal/windows: cleanup interrupt resources
From: Thomas Monjalon <hidden>
Date: 2021-05-11 07:41:35
From: Thomas Monjalon <hidden>
Date: 2021-05-11 07:41:35
02/05/2021 04:33, Dmitry Kozlyuk:
Interrupt manager in Windows EAL allocates on IOCP and starts
a control thread that runs indefinitely. At DPDK cleanup
this thread was not stopped and IOCP handle was not closed.
Gracefully stop interrupt-handling in rte_eal_cleanup().
The thread already closes IOCP handle before exiting.
Fixes: 5c016fc0205a ("eal/windows: add interrupt thread skeleton")
Cc: stable@dpdk.org
Signed-off-by: Dmitry Kozlyuk <redacted>
---
lib/eal/windows/eal.c | 1 +
lib/eal/windows/eal_interrupts.c | 26 ++++++++++++++++++++++++--
lib/eal/windows/eal_windows.h | 5 +++++
3 files changed, 30 insertions(+), 2 deletions(-)It seems nobody reviewed. To be on the safe side, I'll merge this series after DPDK 21.05 is released. Or am I missing any critical issue?