Re: [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD to v2.3.0
From: Michał Krawczyk <hidden>
Date: 2021-05-10 12:02:24
pt., 7 maj 2021 o 16:59 Ferruh Yigit [off-list ref] napisał(a):
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:quoted
Hi, this version updates the driver to version 2.3.0, which fixes multiple bugs, contains part of the work on making the ENA PMD fully MP aware, and also updates HAL to the latest version. More detailed list of changes: * memcpy mapping to the dpdk-optimized version. * ena_com (HAL) update to the latest version. * Bug fixes for the large LLQ headers and devargs parsing. * Mbuf RSS hash presence indication. * Bug fix for the default ring size. * Various fixes for the SMP mode. v3: * Fix build of the PMD with the debug flags enabled. * Fix typo in the commit log of the version upgrade patch. v2: * Fix nested declaration of the rte_memcpy on arm64 architecture. Amit Bernstein (1): net/ena/base: adjust changes to lastest ena-com Igor Chauskin (2): net/ena: switch memcpy to dpdk-optimized version net/ena: fix parsing of large_llq_hdr argument Michal Krawczyk (12): net/ena/base: unify arg names for the functions net/ena/base: add dev arg to the logging macros net/ena/base: typos, style and comments improvements net/ena/base: fix issues from the static code scan net/ena/base: destroy multiple "wait events" net/ena/base: remove indir table from ENA feat ctx net/ena/base: remove mutable RSS from the host info net/ena/base: update generation date and commit net/ena/base: use rte_prefetch0_write net/ena: terminate devargs allowed keys with NULL net/ena: indicate Rx RSS hash presence net/ena: update version to v2.3.0 Stanislaw Kardach (7): net/ena: remove endian swap functions net/ena: handle spurious wakeups in ENA_WAIT_EVENT net/ena: support SMP for mz alloc counter net/ena: move default RSS key to shared mem net/ena: make ethdev references smp safe net/ena: disable dev_ops not supported in SMP net/ena: report default ring sizeHi Michal, There are some checkpatch and check-git-log.sh [1] warnings, can you please check them?
Hi Ferruh, sure, I'll check them all and fix whatever is possible. The problem is with some of the HAL patches, which are just touching some lines on which the checkpatch returns a warning. Many of them aren't related to those patches, so I don't think we should fix them as part of those commits (like the one you listed below, the following patch just adds ena_dev as an extra input argument). Please let me know what you think about that. Thanks, Michal
quoted hunk ↗ jump to hunk
You can see checkpatch warnings from patchwork: https://patches.dpdk.org/project/dpdk/list/?series=16861 The ones with yellow marker in the warning column. Additionally I am getting following checkpatch warning, that is not seen in CI: ### net/ena/base: add dev arg to the logging macros WARNING:UNNECESSARY_MODIFIER: Integer promotion: Using 'h' in '%hu' is unnecessary #331: FILE: drivers/net/ena/base/ena_com.c:861: + ena_trc_err(ena_dev, "Reading reg failed for timeout. expected: req id[%hu] offset[%hu] actual: req id[%hu] offset[%hu]\n", mmio_read->seq_num, offset, read_resp->req_id,@@ -854,7 +868,7 @@ static u32 ena_com_reg_bar_read32(struct ena_com_dev*ena_dev, u16 offset) [1] ./devtools/check-git-log.sh -22