Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx5: fix tunnel offload private items location
From: Gregory Etelson <hidden>
Date: 2021-05-06 07:40:22
From: Gregory Etelson <hidden>
Date: 2021-05-06 07:40:22
Hello Ferruh, [:snip:]
quoted
btw, I can see 'MLX5_RTE_FLOW_ITEM_TYPE_TUNNEL' still checked if it in the first location of the items (items[0].type), in 'flow_dv_validate()', 'mlx5_flow_dv.c'https://git.dpdk.org/dpdk/tree/drivers/net/mlx5/mlx5_flow_dv.c?h=v21.0quoted
5-rc1#n6298 Can you please confirm that this is expected?The `items` variable in that function iterates on pattern array: for (; items->type != RTE_FLOW_ITEM_TYPE_END; items++) { In this scenario, case MLX5_RTE_FLOW_ITEM_TYPE_TUNNEL: if (items[0].type != (typeof(items[0].type))MLX5_RTE_FLOW_ITEM_TYPE_TUNNEL) compares items with itself.
I'll post an updated patch. Regards, Gregory