Thread (60 messages) 60 messages, 9 authors, 2021-07-09

Re: [dpdk-dev] [PATCH v3 2/2] ring: use wfe to wait for ring tail update on aarch64

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2021-04-28 17:17:21

On Sun, 25 Apr 2021 05:56:53 +0000
Ruifeng Wang [off-list ref] wrote:
Instead of polling for tail to be updated, use wfe instruction.

Signed-off-by: Gavin Hu <redacted>
Signed-off-by: Ruifeng Wang <redacted>
Reviewed-by: Steve Capper <redacted>
Reviewed-by: Ola Liljedahl <redacted>
Reviewed-by: Honnappa Nagarahalli <redacted>
Acked-by: Konstantin Ananyev <redacted>
Looks ok to me, but it does raise an interesting question.
Shouldn't the original code have been using atomic load to look at ht->tail.

This another place where "volatile considered harmful" applies.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help