Hi Akhil,

-----Original Message-----
From: Akhil Goyal <redacted>
Sent: Wednesday 31 March 2021 15:46
To: Power, Ciara <redacted>; dev@dpdk.org
Cc: Doherty, Declan <redacted>; hemant.agrawal@nxp.com;
Anoob Joseph [off-list ref]; ruifeng.wang@arm.com;
asomalap@amd.com; ajit.khaparde@broadcom.com; g.singh@nxp.com;
aconole@redhat.com
Subject: RE: [dpdk-dev] [PATCH 5/6] test/crypto: dynamically build
blockcipher suite

Hi Ciara,

Nice work. I have below comment on the output of the results.

++ more crypto PMD maintainers.

quoted

In the existing implementation, the blockcipher test cases are being
run and reported as one test case per type, even though multiple test
cases are hidden in each. For example, "test_AES_chain_all" runs 46 test

cases.

quoted

Each blockcipher type should have a testsuite instead.

The blockcipher testsuite is dynamically built, depending on the
blockcipher type chosen. The testcase struct is modified to allow
running a testcase with data, which is used for data required when
running each blockcipher testcase.

The blockcipher testsuites are added dynamically to parent testsuites
as sub-testsuites where needed.

Signed-off-by: Ciara Power <redacted>
---

When I run the patchset, The output I got is
+ Sub Testsuites Total :       24
+ Sub Testsuites Skipped :      2
+ Sub Testsuites Passed :      22
+ Sub Testsuites Failed :       0

Is it possible for you to give more details in the end like Number of tests
passed/failed/skipped/unsupported as well for each of the suite.

The reason is that, people normally check the report in the end.
For example:
Crypto General(A/X passed, B/X skipped, C/X failed) //one line for each of the
suite.


Regards,
Akhil

Yes, that is a good suggestion.
I have added this extra detail in the v2.
https://patchwork.dpdk.org/project/dpdk/list/?series=16085

Thanks!