Re: [dpdk-dev] [PATCH 03/52] common/cnxk: add model init and IO handling API

On Fri, Mar 26, 2021 at 07:18:35PM +0530, Jerin Jacob wrote:

On Fri, Mar 5, 2021 at 7:10 PM Nithin Dabilpuram
[off-list ref] wrote:

quoted

From: Jerin Jacob <redacted>

Add routines for SoC model identification and HW IO handling
routines specific to CN9K and CN10K Marvell SoC's.
These are based on arm64 ISA and behaviour specific to
Marvell SoC's.

Signed-off-by: Jerin Jacob <redacted>
---
 drivers/common/cnxk/meson.build      |   4 +-
 drivers/common/cnxk/roc_api.h        |  13 +++
 drivers/common/cnxk/roc_io.h         | 187 +++++++++++++++++++++++++++++++++++
 drivers/common/cnxk/roc_io_generic.h | 122 +++++++++++++++++++++++
 drivers/common/cnxk/roc_model.c      | 148 +++++++++++++++++++++++++++
 drivers/common/cnxk/roc_model.h      | 103 +++++++++++++++++++
 drivers/common/cnxk/roc_platform.c   |  21 ++++
 drivers/common/cnxk/roc_platform.h   |  10 ++
 drivers/common/cnxk/roc_priv.h       |  11 +++
 drivers/common/cnxk/roc_util_priv.h  |  14 +++
 drivers/common/cnxk/roc_utils.c      |  35 +++++++
 drivers/common/cnxk/roc_utils.h      |  13 +++
 drivers/common/cnxk/version.map      |   5 +
 13 files changed, 685 insertions(+), 1 deletion(-)
+
+#endif /* _ROC_UTIL_PRIV_H_ */

diff --git a/drivers/common/cnxk/roc_utils.c b/drivers/common/cnxk/roc_utils.c
new file mode 100644
index 0000000..bcba7b2
--- /dev/null
+++ b/drivers/common/cnxk/roc_utils.c

@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2020 Marvell.

Please update the year to 2021 in all the files.

Ack.

quoted

+#endif /* _ROC_UTILS_H_ */

diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
index dc012a1..227f2ce 100644
--- a/drivers/common/cnxk/version.map
+++ b/drivers/common/cnxk/version.map

@@ -1,4 +1,9 @@
 INTERNAL {
+       global:
+
+       plt_init;

plt_init() is internal one. We dont need to expose that.

plt_init() is being used by net/cnxk, event/cnxk and mempool/cnxk PMD's hence I
added it to version.map. To maintain similarity, I'll change it to
roc_plt_init().

quoted

+       roc_error_msg_get;
+       roc_model;

        local: *;
 };
--
2.8.4