On Wed, Mar 31, 2021 at 12:16:59PM +0000, Juraj Linkeš wrote:

Bruce, what do you think of the patch now? Do we need to add/change anything else, like documentation?

One thing to note is that we're changing the default behavior in this patch from machine=native to machine=generic (or more accurately, to cpu_instruction_set=generic). Do we want to do that?

The patch in general looks ok, but I am uncertain about this change indeed.
Especially since the -march flag we mirror to the pkg-config file. I'd like
to see something like [1] included along with such a change. It allows us
per-arch to select the flags to send to the pkg-config file, rather than
just always using machine_args blindly.

Feedback appreciated.

/Bruce

[1] http://patches.dpdk.org/project/dpdk/patch/20201211155111.145279-1-bruce.richardson@intel.com/