Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option
From: Xia, Chenbo <hidden>
Date: 2021-03-31 08:31:13
quoted hunk ↗ jump to hunk
-----Original Message----- From: Ibtisam Tariq <redacted> Sent: Thursday, February 4, 2021 4:06 PM To: maxime.coquelin@redhat.com; Xia, Chenbo <redacted> Cc: dev@dpdk.org; Ibtisam Tariq <redacted>; Zhang, Roy Fan [off-list ref] Subject: [PATCH] examples/vhost_crypto: remove unused short option Short option "s" was passed to getopt_long function, while there was no condition on this option. Fixes: f5188211c7 ("examples/vhost_crypto: add sample application") Cc: roy.fan.zhang@intel.com Signed-off-by: Ibtisam Tariq <redacted> --- examples/vhost_crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index 29c8f7228..66bde38c0 100644 --- a/examples/vhost_crypto/main.c +++ b/examples/vhost_crypto/main.c@@ -219,7 +219,7 @@ vhost_crypto_parse_args(int argc, char **argv) argvopt = argv; - while ((opt = getopt_long(argc, argvopt, "s:", + while ((opt = getopt_long(argc, argvopt, "", lgopts, &option_index)) != EOF) { switch (opt) { --2.17.1
Fix two things before apply: 1. Change Fix commit id to 12 digits. 2. Add cc to stable tag and cc to stable as it needs backport. With above fix, patch applied to next-virtio/main. Thanks!